Conversation
* BubbleColumnLES test works with the new of12 module. Uses populationBalance and mass transfer. * mesh_500mL generates a STR mesh using snappyHexMesh
* The old solver is updated as well as some stuff was missing * The new solver also checks for anisotropy in the variations to discard local maxima/minima from the interface
* Removed critical point check for interface tracking. I have to think it through a bit more. * Updated rotating mesh STR with correct patch creation * Added compression and interface tracking to rotating mesh STR tutorial * Rotating mesh STR has been succesfully tested for air/water in Earth, Moon, and space gravity
This can be used to compute the kLA. First compute mdoti = Su + Sp*Yi (no matter the phase). Then kLA = mdoti / ( Yi,g - Yi,l ) with sign depending on the phase chosen for computing mdoti.
* New geometry and properties * Added switch for disabling energy solution
* This model is an alternative to the reactingPhase model that adds an uptake rate to a specie. The DCW should be provided as a scalarField.
Added a README file for the tetrahedron unstructured grid tutorial, detailing features, usage, and example results.
Copy STR.zip to the current directory before unzipping.
* Added tutorial for rotating mesh * Removed obsolete tutorials * Data such as figs is in its separate directory * Renamed MRF tutorial
-------------------- * Organized and separated old OF9 and new OF13 solvers * Separated tutorials * Separated experimental cases
Collaborator
Author
|
NOTE @malihass : the unit test should be updated to point to the new directories. |
malihass
requested changes
Jun 4, 2026
Collaborator
There was a problem hiding this comment.
Thanks for fixing the CI tests! I have a few other extra requests:
- Experimental case
- I’d prefer if we had just the base case, not the “generateCases.py” and “simParameters.py”
- The post_processing folder should be either integrated into base_case or removed. In general, we just want each folder to be a different configuration. The outer loop manipulation (parametric study and post process) would be up to the user.
- It would be good to add a small readme that explains what is the configuration. If you have a small image, that would be even better
- Tutorial case
- Can you make sure that there is one folder per case. I see that bubble_column and STR* are cases. But could you move data and geometry to the right tutorial case?
- It would be good if you could run the tutorial cases of OF13 as part of the CI. You can probably follow what I did for OF9 and it seems like https://github.com/gerlero/setup-openfoam supports open foam 13 too. When you add the regression test, you would need to make the tutorial case small, add a run.sh and make sure they run over 1 timestep only.
- Same as the experimental case, can you add a small readme that explains what is the bubble column case?
- Docs
- Can you also add modifs to index.rst ( I think it still says OF 9 everywhere)
- It might be good to add a subsection to Multiphase flow model that explains the capabilities of OF13 vs OF9. In particular, you have the interface compression stuff that would be good to explain there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging OpenFOAM-13 developments into main
This adds the new OpenFOAM-13 solver to the main, including tutorial with rotating mesh.